From 773c3c733db6fd5d0b2cbe1ec35f7e3abc4169b3 Mon Sep 17 00:00:00 2001 From: "Jasper v. B" Date: Mon, 15 Aug 2016 23:24:32 +0200 Subject: [PATCH 1/2] Update PR template Remove the @mentions because I'm watching the repository and LongLiveCHIEF no longer maintains it. --- .github/PULL_REQUEST_TEMPLATE.md | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index ae22d79..1b3c90e 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,14 +1,15 @@ Fixes # . Changes Proposed in this Pull Request: -- -- -- + +- foo +- bar +- baz I have written tests for: -- [ ] New features introduced -- [ ] Bugs fixed -- [ ] Neither (I'm just enhancing tests!) +[](Remove the `[]()` to uncomment the appropriate lines) -@jazzpi @LongLiveCHIEF +[](- New features introduced) +[](- Bugs fixed) +[](- Neither (I'm just enhancing tests!)) From a450f5853fef15567ef5f785a353a4fed36726d0 Mon Sep 17 00:00:00 2001 From: "Jasper v. B" Date: Mon, 15 Aug 2016 23:31:08 +0200 Subject: [PATCH 2/2] Update contributing guidelines LongLiveCHIEF no longer maintains this repository and I'm watching it, so the @mentions are unnecessary. Also, only collaborators can assign issues so step #2 doesn't work anyways. --- .github/CONTRIBUTING.md | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 31132f0..2231100 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -3,13 +3,8 @@ Current Maintainers: - [@jazzpi](https://github.com/jazzpi) -- [@LongLiveCHIEF](https://github.com/LongLiveCHIEF) -This project is accepting new maintainers. Interested parties should - -1. Open a new issue, titled: `New Maintainer Request` -2. Assign the issue to [@lloeki](https://github.com/lloeki) -3. The last line of your request should `/cc @jazzpi @LongLiveCHIEF` +This project is accepting new maintainers. Interested parties should open a new issue titled `New Maintainer Request`. ## Pull Requests @@ -19,7 +14,6 @@ close when your PR is merged to speed up the merge of your PR, please contribute these tests - *note*: if you submit a PR but are unsure how to write tests, please begin your PR title with `[needs tests]` - Please use the [pull request template](PULL_REQUEST_TEMPLATE.md) as a guide for submitting your PR. -- Include a `/cc` for @LongLiveCHIEF and @jazzpi the current maintainers ## Issues