From 3a33a695852514489796897ebe63f9785746ad30 Mon Sep 17 00:00:00 2001 From: Thomas Kienlen Date: Fri, 2 Jun 2017 17:13:26 +0200 Subject: [PATCH] need a better solution for: by(:foo).asc.by(:bar).desc --- lib/rebel/sql.rb | 6 +++--- test/test_exec.rb | 2 +- test/test_raw.rb | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/rebel/sql.rb b/lib/rebel/sql.rb index 0aa81e2..b425f6b 100644 --- a/lib/rebel/sql.rb +++ b/lib/rebel/sql.rb @@ -156,9 +156,9 @@ module Rebel::SQL Raw.new("#{self} DESC") end - def by(*clause) - Raw.new(Rebel::SQL.list(self, Rebel::SQL.names(*clause))) - end + # def by(*clause) + # Raw.new(Rebel::SQL.list(self, Rebel::SQL.names(*clause))) + # end end @identifier_quote = '"' diff --git a/test/test_exec.rb b/test/test_exec.rb index 1b95d06..bef1408 100644 --- a/test/test_exec.rb +++ b/test/test_exec.rb @@ -61,6 +61,6 @@ class TestExec < Minitest::Test insert_into :foo, id: 3, value: '1', col: 'else' assert_equal(select(:id, from: :foo, order: by(:id).desc), [[3], [2], [1]]) assert_equal(select(:id, from: :foo, order: by(:value, :id).asc), [[3], [1], [2]]) - assert_equal(select(:id, from: :foo, order: by(:value).asc.by(:id).desc), [[3], [2], [1]]) + # assert_equal(select(:id, from: :foo, order: by(:value).asc.by(:id).desc), [[3], [2], [1]]) end end diff --git a/test/test_raw.rb b/test/test_raw.rb index 6ad1a1d..575556f 100644 --- a/test/test_raw.rb +++ b/test/test_raw.rb @@ -108,6 +108,6 @@ class TestRaw < Minitest::Test def test_by assert_str_equal(Rebel::SQL.by(:foo), 'BY "foo"') assert_str_equal(Rebel::SQL.by(:foo).desc, 'BY "foo" DESC') - assert_str_equal(Rebel::SQL.by(:foo).desc.by(:bar).asc, 'BY "foo" DESC, "bar" ASC') + # assert_str_equal(Rebel::SQL.by(:foo).desc.by(:bar).asc, 'BY "foo" DESC, "bar" ASC') end end